Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kill raw part when getting mutable reference to typed header #833

Closed
wants to merge 1 commit into from

Conversation

andresilva
Copy link
Contributor

Fixes #821.

@GitCop
Copy link

GitCop commented Jun 17, 2016

Thanks for contributing! Unfortunately, I'm here to tell you there were the following style issues with your Pull Request:

  • Commit: c471ce6
    • Commits must be in the following format: %{type}(%{scope}): %{description}

Guidelines are available at https://github.com/hyperium/hyper/blob/master/CONTRIBUTING.md


This message was auto-generated by https://gitcop.com

@andresilva andresilva force-pushed the fix-item-typed_mut branch from c471ce6 to 084072c Compare June 17, 2016 01:02
@seanmonstar
Copy link
Member

Thanks! Just a couple comments.

  • I think a typed could exist from parsing by getting typed(), and then later on a call to typed_mut() would not remove the raw representation.
  • Could you add a couple tests for the multiple combinations that might cause it to be out of sync?
  • Since the commit message becomes part of the changelog, could it be something tamer? :D Maybe just replacing "kill" with "remove"?

… header

If you get a mutable reference to a typed header it is possible to make
the two representations be out of sync. To avoid this, after parsing the
raw part it should be removed.

Fixes hyperium#821.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants