Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 0.9.x build with --no-default-features --features=security-framework #820

Merged
merged 1 commit into from
Jun 9, 2016

Conversation

luser
Copy link

@luser luser commented Jun 6, 2016

Fixes #819

@GitCop
Copy link

GitCop commented Jun 6, 2016

Thanks for contributing! Unfortunately, I'm here to tell you there were the following style issues with your Pull Request:

  • Commit: c65e0c9
    • Commits must be in the following format: %{type}(%{scope}): %{description}

Guidelines are available at https://github.com/hyperium/hyper/blob/master/CONTRIBUTING.md


This message was auto-generated by https://gitcop.com

@luser luser force-pushed the fix-security-framework-0.9.x branch from c65e0c9 to 2bc5d0f Compare June 6, 2016 12:46
@GitCop
Copy link

GitCop commented Jun 6, 2016

Thanks for contributing! Unfortunately, I'm here to tell you there were the following style issues with your Pull Request:

  • Commit: 2bc5d0f
    • Commits must be in the following format: %{type}(%{scope}): %{description}

Guidelines are available at https://github.com/hyperium/hyper/blob/master/CONTRIBUTING.md


This message was auto-generated by https://gitcop.com

@luser luser force-pushed the fix-security-framework-0.9.x branch from 2bc5d0f to 496db4a Compare June 6, 2016 12:47
@GitCop
Copy link

GitCop commented Jun 6, 2016

Thanks for contributing! Unfortunately, I'm here to tell you there were the following style issues with your Pull Request:

  • Commit: 496db4a
    • Commits must be in the following format: %{type}(%{scope}): %{description}

Guidelines are available at https://github.com/hyperium/hyper/blob/master/CONTRIBUTING.md


This message was auto-generated by https://gitcop.com

@luser luser force-pushed the fix-security-framework-0.9.x branch from 496db4a to a51c1e9 Compare June 6, 2016 12:48
…s=security-framework`

The build on OS X was broken in this configuration.

Fixes hyperium#819
@luser luser force-pushed the fix-security-framework-0.9.x branch from a51c1e9 to 6caffe9 Compare June 6, 2016 12:50
@luser
Copy link
Author

luser commented Jun 6, 2016

Sorry for the zillion commits, took me a while to figure out what gitcop wanted. :)

@seanmonstar
Copy link
Member

Woo! Thanks for the pull request!

Please excuse my tardiness. I'm traveling, very little computer time.

@seanmonstar seanmonstar merged commit 3e3e036 into hyperium:0.9.x Jun 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants