Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(headers) Add Access-Control-Allow-Credentials header #692

Closed
wants to merge 1 commit into from
Closed

feat(headers) Add Access-Control-Allow-Credentials header #692

wants to merge 1 commit into from

Conversation

brycefisher
Copy link

There is only one acceptable value for this header, "true", so
there header struct is unit-like (no fields nor data inside). See
documentation and tests for more info.

Closes #655

There is only one acceptable value for this header, "true", so
there header struct is unit-like (no fields nor data inside). See
documentation and tests for more info.

Closes #655
@GitCop
Copy link

GitCop commented Nov 22, 2015

Thanks for contributing! Unfortunately, I'm here to tell you there were the following style issues with your Pull Request:

  • Commit: f18ae05
    • Commits must be in the following format: %{type}(%{scope}): %{description}

Guidelines are available at https://github.com/hyperium/hyper/blob/master/CONTRIBUTING.md


This message was auto-generated by https://gitcop.com

@brycefisher
Copy link
Author

😭 I forgot the colon.... sinc Ryman just suggested an improvement over my impl, I'm going to close and fix up this commit with his suggestions once the tests pass.

@brycefisher brycefisher deleted the feat/access-control-allow-credentials branch November 22, 2015 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants