fix(server): use a timeout for Server keep-alive #661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| self.handler.on_connection_end(); | ||
|
|
||
| debug!("keep_alive loop ending for {}", addr); | ||
| } | ||
|
|
||
| fn set_timeouts(&self, s: & &mut NetworkStream) -> io::Result<()> { |
There was a problem hiding this comment.
The double indirection is crappy, but using a generic wasn't really possible, since the type is erased into a trait object inside the keep alive loop. And since NetworkStream requires 'static, I couldn't implement the trait for &mut T. Fun.
Server keep-alive is now **off** by default. In order to turn it on, the `keep_alive` method must be called on the `Server` object. Closes #368
seanmonstar
force-pushed
the
keep-alive-timeout
branch
from
9482614
to
cdaa254
Compare
seanmonstar
added a commit
that referenced
this pull request
Oct 9, 2015
fix(server): use a timeout for Server keep-alive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Server keep-alive is now off by default. In order to turn it on, the
keep_alivemethod must be called on theServerobject.Closes #368