feat(error): add Ssl variant to hyper::Error #506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, this sounds like it could be much more useful than https://github.com/servo/servo/blob/master/components/net/http_loader.rs#L140 ! |
|
I wish we could pull the |
|
@reem yea, i'd like that too, but I assume there will be a solution by the time hyper hits 1.0. |
The errors from openssl were previously boxed into a Box<std::error::Error>, which lost some specifics and made it difficult to match against. To solve this, an `Ssl` variant is added to the `Error` enum of hyper, and is returned when openssl returns specific errors. Closes #483 BREAKING CHANGE: Adds a variant to `hyper::Error`, which may break any exhaustive matches.
seanmonstar
added a commit
that referenced
this pull request
May 6, 2015
feat(error): add Ssl variant to hyper::Error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The errors from openssl were previously boxed into a
Boxstd::error::Error, which lost some specifics and made it difficult
to match against. To solve this, an
Sslvariant is added to theErrorenum of hyper, and is returned when openssl returns specificerrors.
Closes #483
BREAKING CHANGE: Adds a variant to
hyper::Error, which may break anyexhaustive matches.
cc @jdm