-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(server): add h1 idle_timeout
#3743
Open
finnbear
wants to merge
1
commit into
hyperium:master
Choose a base branch
from
finnbear:idle_timeout
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
finnbear
commented
Aug 24, 2024
finnbear
commented
Aug 24, 2024
finnbear
commented
Aug 24, 2024
1 task
finnbear
force-pushed
the
idle_timeout
branch
2 times, most recently
from
August 26, 2024 20:27
4362e38
to
d76e8d8
Compare
@sfackler / @seanmonstar is there a possibility on getting this PR reviewed? I am also interested in getting H1 idle timeouts available :) |
If you want, you can use the TOML snippet in my PR description to avoid needing to wait for review :) |
Dav1dde
added a commit
to getsentry/relay
that referenced
this pull request
Nov 14, 2024
With the idle time configurable we can prevent a pile up of open connections which never see any activity. See also on the hyper issue tracker: ``` hyperium/hyper#3743 hyperium/hyper#1628 hyperium/hyper#2355 hyperium/hyper#2827 ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Older browsers sometimes open 6 or more H1 connections and keep them alive and idle after resources are loaded, costing server resources and distracting from DoS attackers. In my specific case, DoS mitigation required limiting TCP connections per IP address, but limits had to be high to account for multiple legitimate H1 browsers on the same IP address.
Related: #1628
Related: #2355
Changes
idle_timeout
setting, optimized to avoid creating an additional timer per requestAutomatically send(deferred due to: Consider providing constants for keep-alive and proxy-connection header names. http#142)keep-alive: timeout=#
headerTesting
Future work
hyper-util
(feat(server): add support foridle_timeout
. hyper-util#146)