Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix confusing usage of TokioTimer in hello.rs example #3658

Merged
merged 2 commits into from
May 10, 2024
Merged

Fix confusing usage of TokioTimer in hello.rs example #3658

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
49f42db
fix(example): change TokioTimer usage to match hyper-util end-user ex…
krakow10 May 5, 2024
f510242
Merge branch 'master' into fix-hello
tottoto May 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions benches/support/tokiort.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,13 @@ impl Timer for TokioTimer {
}
}

impl TokioTimer {
/// Create a new TokioTimer
pub fn new() -> Self {
Self {}
}
}

// Use TokioSleep to get tokio::time::Sleep to implement Unpin.
// see https://docs.rs/tokio/latest/tokio/time/struct.Sleep.html
pin_project! {
Expand Down
2 changes: 1 addition & 1 deletion examples/hello.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ pub async fn main() -> Result<(), Box<dyn std::error::Error + Send + Sync>> {
// Handle the connection from the client using HTTP1 and pass any
// HTTP requests received on that connection to the `hello` function
if let Err(err) = http1::Builder::new()
.timer(TokioTimer)
.timer(TokioTimer::new())
.serve_connection(io, service_fn(hello))
.await
{
Expand Down
Loading