Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(client): auto content-length failing on curl #3632

Closed
wants to merge 1 commit into from
Closed

fix(client): auto content-length failing on curl #3632

wants to merge 1 commit into from

Conversation

dswij
Copy link
Member

@dswij dswij commented Apr 16, 2024 •
edited
Loading

This PR now adds content-length to header automatically only when content-type is present.

This is also the case according to seanmonstar/reqwest#2240 (comment)

See 172fdfa#commitcomment-141005865, curl/curl#13380

@dswij dswij changed the title fix: auto content-length failing on curl fix(client): auto content-length failing on curl Apr 16, 2024
@seanmonstar
Copy link
Member

I'm just going to revert it entirely: #3633

@dswij
Copy link
Member Author

dswij commented Apr 16, 2024 •
edited
Loading

Fair enough. I'm agreeing with curl/curl#13380 (comment) on hyper's "intelligence"

@dswij dswij closed this Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dswij @seanmonstar