feat(client): support Expect: 100-continue #3472
Open
+118
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch modifies hyper clients to respect the
Expect: 100-Continue
header.When the header is present on a request, the client will not send the request body
until the
100 Continue
informational response is received from the server.Related issue: #2565
The implementation follows the existing
on_informational
callback mechanism,threading the connection state through to the reponse header parsing.
This seems like the most straightforward modification to get
Expect: 100-Continue
support, but happy to discuss alternatives.