-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved send_file.rs example to use streaming. #3433
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So far I noticed these two changes.
Co-authored-by: Sean McArthur <[email protected]>
Co-authored-by: Sean McArthur <[email protected]>
We still have build errors: and line 61 mismatched types |
Co-authored-by: Sean McArthur <[email protected]>
You'll need to use |
I am not sure what you mean by |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested out all the rest of the changes I'm suggested, and it works at the end.
Co-authored-by: Sean McArthur <[email protected]>
Co-authored-by: Sean McArthur <[email protected]>
Co-authored-by: Sean McArthur <[email protected]>
I can also confirm that it builds and works. Now ready to pull. |
…rium#3433) Signed-off-by: Sven Pfennig <[email protected]>
This is to show what I have wrote so far. It does not compile in the current state.
This addresses issues #3432