fix(client): add missing without_shutdown method #3430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiron1
force-pushed
the
hyper-1.0-client-without_shutdown
branch
from
ec5c388 to
e1cb83d
Compare
kiron1
force-pushed
the
hyper-1.0-client-without_shutdown
branch
from
e1cb83d to
ce1e2b5
Compare
seanmonstar
reviewed
Nov 20, 2023
seanmonstar
approved these changes
Nov 21, 2023
0xE282B0
pushed a commit
to 0xE282B0/hyper
that referenced
this pull request
Jan 12, 2024
0xE282B0
pushed a commit
to 0xE282B0/hyper
that referenced
this pull request
Jan 16, 2024
…perium#3430) Signed-off-by: Sven Pfennig <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in
client::conn::http1::Connectionthe methodpoll_without_shutdownreferenceswithout_shutdownin its documentation, but the methodwithout_shutdownis not present in the code. This PR copieswithout_shutdownfrom hyper0.14.x: https://github.com/hyperium/hyper/blob/0.14.x/src/client/conn.rs#L520-L528