Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Read/Write for Pin<P> #3413

Merged
merged 1 commit into from
Nov 16, 2023
Merged

Implement Read/Write for Pin<P> #3413

merged 1 commit into from
Nov 16, 2023

Conversation

coolreader18
Copy link
Contributor

Closes #3412

@coolreader18
fix: implement Read/Write for Pin<P>
0aad32b 
Without these impls, something like Pin<Box<T: Read>> does not actually
implement Read.

Closes hyperium#3412

BREAKING CHANGE: Pin is #[fundamental], so this theoretically conflicts
  with existing user Read/Write for Pin<...> impls. However, those impls
  probably don't exist yet.
@seanmonstar seanmonstar merged commit dd6d81c into hyperium:master Nov 16, 2023
20 checks passed
@coolreader18 coolreader18 deleted the impl-io-for-pin branch November 16, 2023 16:40
@coolreader18
Copy link
Contributor Author

Oh, woah, wild, I was looking in the Rust changelog for something totally unrelated to this and found rust-lang/rust#81363, which shows it was sorta an under-specification of Pin at the time.

0xE282B0 pushed a commit to 0xE282B0/hyper that referenced this pull request Jan 12, 2024
@coolreader18 @0xE282B0
fix(rt): implement Read/Write for Pin<P> (hyperium#3413)
d8dd394 
Without these impls, something like Pin<Box<T: Read>> does not actually
implement Read.

Closes hyperium#3412

BREAKING CHANGE: Pin is #[fundamental], so this theoretically conflicts
  with existing user Read/Write for Pin<...> impls. However, those impls
  probably don't exist yet.
0xE282B0 pushed a commit to 0xE282B0/hyper that referenced this pull request Jan 16, 2024
@coolreader18 @0xE282B0
fix(rt): implement Read/Write for Pin<P> (hyperium#3413)
e755eef 
Without these impls, something like Pin<Box<T: Read>> does not actually
implement Read.

Closes hyperium#3412

BREAKING CHANGE: Pin is #[fundamental], so this theoretically conflicts
  with existing user Read/Write for Pin<...> impls. However, those impls
  probably don't exist yet.

Signed-off-by: Sven Pfennig <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanmonstar seanmonstar seanmonstar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing impl Read/Write for Pin<P>
2 participants
@coolreader18 @seanmonstar