Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(body:incoming): reference http-body-incoming for more explain #3383

Merged
merged 7 commits into from
Nov 13, 2023

Conversation

ZhangHanDong
Copy link
Contributor

for Polish the API docs : body-incoming

Copy link
Member

@seanmonstar seanmonstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much!

.gitignore Outdated Show resolved Hide resolved
doc(body:incoming): reference http-body-incoming for more explain:update

doc(body:incoming): reference http-body-incoming for more explain:delete .vscode
@seanmonstar
Copy link
Member

It looks like rustfmt is noticing some trailing spaces.

@ZhangHanDong
Copy link
Contributor Author

@seanmonstar CI testing and miri errors shouldn't have anything to do with the document I modified, right? How should this problem be solved?

@ZhangHanDong
Copy link
Contributor Author

In my fork branch, ci only has one error.

Screenshot 2023-11-13 at 20 24 08

Miri test error:

test proto::h1::role::tests::test_client_request_encode_orig_case ... ok
error: Undefined Behavior: trying to retag from <2087702> for Unique permission at alloc591422[0x28], but that tag only grants SharedReadOnly permission for this location
    --> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/http-0.2.10/src/header/map.rs:2111:35
     |
2111 |         let entry = unsafe { &mut (*self.map).entries[self.entry] };
     |                                   ^^^^^^^^^^^^^^^^^^^
     |                                   |
     |                                   trying to retag from <2087702> for Unique permission at alloc591422[0x28], but that tag only grants SharedReadOnly permission for this location
     |                                   this error occurs as part of retag at alloc591422[0x28..0x40]
     |
     = help: this indicates a potential bug in the program: it performed an invalid operation, but the Stacked Borrows rules it violated are still experimental
     = help: see https://github.com/rust-lang/unsafe-code-guidelines/blob/master/wip/stacked-borrows.md for further information
help: <2087702> was created by a SharedReadOnly retag at offsets [0x0..0x60]
    --> src/proto/h1/role.rs:1473:26
     |
1473 |     for (name, value) in headers {
     |                          ^^^^^^^
     = note: BACKTRACE (of the first span):
     = note: inside `http::header::IterMut::<'_, http::HeaderValue>::next_unsafe` at /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/http-0.2.10/src/header/map.rs:2111:35: 2111:54
     = note: inside `<http::header::Iter<'_, http::HeaderValue> as std::iter::Iterator>::next` at /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/http-0.2.10/src/header/map.rs:2081:9: 2082:27
note: inside `proto::h1::role::write_headers_title_case`
    --> src/proto/h1/role.rs:1473:26
     |
1473 |     for (name, value) in headers {
     |                          ^^^^^^^
note: inside `<proto::h1::role::Client as proto::h1::Http1Transaction>::encode`
    --> src/proto/h1/role.rs:1129:13
     |
1129 |             write_headers_title_case(&msg.head.headers, dst);
     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
note: inside `proto::h1::role::tests::test_client_request_encode_title_case`
    --> src/proto/h1/role.rs:2407:9
     |
2407 | /         Client::encode(
2408 | |             Encode {
2409 | |                 head: &mut head,
2410 | |                 body: Some(BodyLength::Known(10)),
...    |
2415 | |             &mut vec,
2416 | |         )
     | |_________^
note: inside closure
    --> src/proto/h1/role.rs:2395:47
     |
2394 |     #[test]
     |     ------- in this procedural macro expansion
2395 |     fn test_client_request_encode_title_case() {
     |                                               ^
     = note: this error originates in the attribute macro `test` (in Nightly builds, run with -Z macro-backtrace for more info)

note: some details are omitted, run with `MIRIFLAGS=-Zmiri-backtrace=full` for a verbose backtrace

error: aborting due to previous error; 15 warnings emitted

error: test failed, to rerun pass `--lib`

Caused by:
  process didn't exit successfully: `/home/runner/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/bin/cargo-miri runner /home/runner/work/hyper/hyper/target/miri/x86_64-unknown-linux-gnu/debug/deps/hyper-ac7a2b0[313](https://github.com/ZhangHanDong/hyper/actions/runs/6849816623/job/18622770372#step:5:314)3a5[322](https://github.com/ZhangHanDong/hyper/actions/runs/6849816623/job/18622770372#step:5:323)` (exit status: 1)
note: test exited abnormally; to see the full output pass --nocapture to the harness.
test proto::h1::role::tests::test_client_request_encode_title_case ... 
Error: Process completed with exit code 1.

@seanmonstar
Copy link
Member

No, you don't need to do anything, something else has caused CI to break. We're looking into it.

@seanmonstar seanmonstar merged commit c22fc07 into hyperium:master Nov 13, 2023
19 checks passed
@seanmonstar seanmonstar mentioned this pull request Nov 13, 2023
22 tasks
@ZhangHanDong
Copy link
Contributor Author

nice. I will continue contributing.

0xE282B0 pushed a commit to 0xE282B0/hyper that referenced this pull request Jan 12, 2024
And explain that users don't "create" one.

cc hyperium#3067
0xE282B0 pushed a commit to 0xE282B0/hyper that referenced this pull request Jan 16, 2024
And explain that users don't "create" one.

cc hyperium#3067

Signed-off-by: Sven Pfennig <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants