Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

h2: add max_pending_accept_reset_streams configuration option #3201

Merged
merged 7 commits into from
Apr 13, 2023
Merged

h2: add max_pending_accept_reset_streams configuration option #3201

merged 7 commits into from
Apr 13, 2023

Conversation

Noah-Kennedy
Copy link
Contributor

@Noah-Kennedy Noah-Kennedy commented Apr 13, 2023 •
edited
Loading

This allows users to set the configuration option from hyperium/h2#668.

LPardue
LPardue reviewed Apr 13, 2023
View reviewed changes
src/proto/h2/server.rs Outdated Show resolved Hide resolved
nox
nox reviewed Apr 13, 2023
View reviewed changes
src/server/conn.rs Outdated Show resolved Hide resolved
@Noah-Kennedy
h2: add max_pending_accept_reset_streams configuration option
7a0145e 
This allows users to set the configuration option from hyperium/h2#668.
hawkw
hawkw reviewed Apr 13, 2023
View reviewed changes
Cargo.toml Outdated Show resolved Hide resolved
src/proto/h2/server.rs Outdated Show resolved Hide resolved
src/server/conn.rs Outdated Show resolved Hide resolved
@Noah-Kennedy
Copy link
Contributor Author

@hawkw I've addressed your feedback

@seanmonstar
Copy link
Member

Does it seem likely people want to configure this on the client? I'm guessing since hyper disables server push, there's nothing to worry about?

@Noah-Kennedy
Copy link
Contributor Author

Does it seem likely people want to configure this on the client? I'm guessing since hyper disables server push, there's nothing to worry about?

I don't think we need client configuration for now, if someone asks then we can add it IMO.

@Noah-Kennedy
Copy link
Contributor Author

Like you said, we don't support server push anyways for the client.

hawkw
hawkw approved these changes Apr 13, 2023
View reviewed changes
Copy link
Contributor

@hawkw hawkw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some last docs quibbles, but LGTM otherwise!

src/server/conn.rs Outdated Show resolved Hide resolved
@Noah-Kennedy @hawkw
Update src/server/conn.rs
e8296d1 
Co-authored-by: Eliza Weisman <[email protected]>
@Noah-Kennedy
Copy link
Contributor Author

I committed your suggestions

@seanmonstar seanmonstar merged commit a6f7571 into hyperium:0.14.x Apr 13, 2023
@Noah-Kennedy Noah-Kennedy deleted the noah/h2-resets branch April 13, 2023 18:40
bors bot referenced this pull request in TeamHarTex/HarTex Apr 14, 2023
@bors @renovate
Auto merge of #771
b63317c 
771: Update Rust crate hyper to 0.14.26 r=HTG-YT a=renovate[bot]

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [hyper](https://hyper.rs) ([source](https://github.com/hyperium/hyper)) | dependencies | patch | `0.14.25` -> `0.14.26` |

---

### Release Notes

<details>
<summary>hyperium/hyper</summary>

### [`v0.14.26`](https://github.com/hyperium/hyper/releases/tag/v0.14.26)

[Compare Source](https://github.com/hyperium/hyper/compare/v0.14.25...v0.14.26)

#### Features

-   **http2:** add `max_pending_accept_reset_streams` configuration option ([#&#8203;3201](https://github.com/hyperium/hyper/issues/3201)) ([a6f7571a](https://github.com/hyperium/hyper/commit/a6f7571a5299793aef8f1aa4194574438b9df64c))

#### New Contributors

-   [`@&#8203;Noah-Kennedy](https://github.com/Noah-Kennedy)` made their first contribution in [https://github.com/hyperium/hyper/pull/3201](https://github.com/hyperium/hyper/pull/3201)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/TeamHarTex/HarTex).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS40MC4wIiwidXBkYXRlZEluVmVyIjoiMzUuNDAuMCJ9-->


Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@allan2 allan2 mentioned this pull request Dec 7, 2023
Closed
@dsgallups dsgallups mentioned this pull request Dec 28, 2023
Merged
seanmonstar pushed a commit that referenced this pull request Dec 29, 2023
@dsgallups
feat(http2): add max_pending_accept_reset_streams(num) back to HTTP…
a9fa893 
…/2 server builder (#3507)

In places where required, the `max_pending_accept_reset_streams` option was reimplemented, as in PR #3201

cc #3461
cratelyn added a commit to cratelyn/hyper that referenced this pull request Nov 27, 2024
@cratelyn
chore(server/conn): backport max_pending_accept_reset_streams() to …
28f5e67 
…builder

NB: this commit is based on the `0.14.x` release series.

the `server::conn::http2` submodule provides types that are
conditionally compiled when the `backports` feature is active, to
facilitate upgrading to the `1.x` release.

i've been working on upgrading the
[`linkerd2-proxy`](https://github.com/linkerd/linkerd2-proxy/) project
to use hyper 1.0, but encountered some gaps in `Builder<E>`'s interface
when setting the `backports` and `deprecated` features.

this adds a `max_pending_accept_reset_streams(..)` method
(_added in #3201_) to this builder, so that 0.14.x users relying on
this functionality can prepare to upgrade to hyper 1.x safely.

this is effectively a backport of hyperium#3507, which restored this interface
to the 1.0 release.

for more information, see:

* hyperium#3201
* hyperium#3507
* hyperium#3461
* https://hyper.rs/guides/1/upgrading/

Signed-off-by: katelyn martin <[email protected]>
@cratelyn cratelyn mentioned this pull request Nov 27, 2024
Merged
cratelyn added a commit to cratelyn/hyper that referenced this pull request Nov 27, 2024
@cratelyn
chore(server/conn): backport max_pending_accept_reset_streams() to …
403b2d0 
…builder

NB: this commit is based on the `0.14.x` release series.

the `server::conn::http2` submodule provides types that are
conditionally compiled when the `backports` feature is active, to
facilitate upgrading to the `1.x` release.

i've been working on upgrading the
[`linkerd2-proxy`](https://github.com/linkerd/linkerd2-proxy/) project
to use hyper 1.0, but encountered some gaps in `Builder<E>`'s interface
when setting the `backports` and `deprecated` features.

this adds a `max_pending_accept_reset_streams(..)` method
(_added in #3201_) to this builder, so that 0.14.x users relying on
this functionality can prepare to upgrade to hyper 1.x safely.

this is effectively a backport of hyperium#3507, which restored this interface
to the 1.0 release.

for more information, see:

* hyperium#3201
* hyperium#3507
* hyperium#3461
* https://hyper.rs/guides/1/upgrading/

Signed-off-by: katelyn martin <[email protected]>
seanmonstar pushed a commit that referenced this pull request Nov 29, 2024
@cratelyn
feat(server): backport max_pending_accept_reset_streams() to builder (
a24f0c0 
#3796)

the `server::conn::http2` submodule provides types that are
conditionally compiled when the `backports` feature is active, to
facilitate upgrading to the `1.x` release.

i've been working on upgrading the
[`linkerd2-proxy`](https://github.com/linkerd/linkerd2-proxy/) project
to use hyper 1.0, but encountered some gaps in `Builder<E>`'s interface
when setting the `backports` and `deprecated` features.

this adds a `max_pending_accept_reset_streams(..)` method
(_added in #3201_) to this builder, so that 0.14.x users relying on
this functionality can prepare to upgrade to hyper 1.x safely.

this is effectively a backport of #3507, which restored this interface
to the 1.0 release.

for more information, see:

* #3201
* #3507
* #3461
* https://hyper.rs/guides/1/upgrading/

Signed-off-by: katelyn martin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LPardue LPardue LPardue left review comments

@nox nox nox left review comments

@hawkw hawkw hawkw approved these changes

@seanmonstar seanmonstar seanmonstar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Noah-Kennedy @seanmonstar @nox @hawkw @LPardue