refactor(test):#1675 use fns for creating test server #3072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a part of hyperium#1675 issue. It slightly reduces the number of duplicated code by using one common function for init a logger and creating a Tokio server.
This is a part of hyperium#1675 issue. It slightly reduces the number of duplicated code by using one common function for init a logger and creating a std server.
|
This PR doesn't provide any significant changes but allows to make one step in decreasing code duplication. If it's the wrong way, please, just reject the PR. If it brings something useful, then I can continue with it. |
seanmonstar
approved these changes
Dec 5, 2022
|
Happy to help :) There is yet another possibility to reduce boilerplate code. For example, tests often use the pattern "create server and spawn processing" + "create client and do something". Processing and doing something differ from test to test, but creating a server and connecting a client is often very similar. So I can try to generalize them and show the results. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a part of #1675 issue. It
slightly reduces the number of duplicated code by using one common function for
init a logger and creating a test server.