feat(header): Support arbitary status codes #303
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There were the following issues with your Pull Request
Guidelines are available at https://github.com/hyperium/hyper/blob/master/CONTRIBUTING.md This message was auto-generated by https://gitcop.com |
| NetworkAuthenticationRequired, | ||
|
|
||
| /// A method not in the IANA HTTP status code registry. | ||
| UnregisteredStatusCode(u16), |
There was a problem hiding this comment.
Since it's already got the StatusCode namespace, I'd leave this as just 'Unregistered'.
|
Test failure was in a doctest, that |
|
@pyfisch any news here? We'd like to land this to unblock servo/servo#117. |
|
You mean servo/servo#4246 :) |
|
Wow I have no idea what I was looking at. |
As discussed in #177 hyper must support status code outside the standard range for compatibility reasons. BREAKING CHANGE: This removes unregistered status codes from the enum. Use `FromPrimitive` methods to create them now. StatusCode and StatusClass can no longer be casted to `u16`, use `ToPrimitive` methods now. For example `status.to_u16().unwrap()` to get the status code number.
|
If anything is left to do tell me. |
|
I fixed up a couple tiny nits, and pushed this as #311 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #177 hyper must support status code outside the standard range for compatibility reasons.
BREAKING CHANGE: This removes unregistered status codes from the enum. Use FromPrimitive methods to create them now.
StatusCode and StatusClass can no longer be casted to u16, use ToPrimitive methods now.
For example
status.to_u16().unwrap()to get the status code number.