Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply clippy fixes, except in #[test] code #3019

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bossmc
Copy link
Contributor

@bossmc bossmc commented Oct 21, 2022

This also adds a CI stage to run clippy over the project too, hopefully this will prevent degradation.

@bossmc
Copy link
Contributor Author

bossmc commented Oct 24, 2022

Build failure was due to my rustc allowing nightly features by default, I've marked the benches that use #![feature(test)] as also needing #![cfg(feature = nightly)] so they won't get built without the nightly feature enabled.

I've also rebased to pick up the recent master changes.

@bossmc bossmc force-pushed the clippy-changes branch 3 times, most recently from 702e53c to 5907545 Compare October 25, 2022 00:15
@FrankReh
Copy link

I will add it's nice if the project would pass clippy cleanly because it makes playing around with the package easier for a new-comer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants