Rename body to recv temporarily #2966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How easy would it be to separate it from the other PR? I suspect this one could merge faster. |
Michael-J-Ward
force-pushed
the
rename-body-to-recv-temporarily
branch
from
5261c37 to
7039392
Compare
|
I did pop off the commit, I also rebased off of master. on master, this is failing to compile and test. |
Michael-J-Ward
force-pushed
the
rename-body-to-recv-temporarily
branch
from
7039392 to
da70a2e
Compare
|
(forgot to apply |
|
Looks like the last piece remaining is to remove the link to |
""" We'll eventually want to bikshed the name Recv, but to free up the name Body for hyperium#2839, this can be done quickly. """ Resolve hyperium#2963
Michael-J-Ward
force-pushed
the
rename-body-to-recv-temporarily
branch
from
da70a2e to
c21eebc
Compare
RajivTS
added a commit
to RajivTS/hyper
that referenced
this pull request
Aug 28, 2022
Now that the concrete `Body` type has been temporarily replaced with `Recv` in hyperium#2966, we can rename and export `http_body::Body` as just `Body` instead of `HttpBody`. Closes hyperium#2839
RajivTS
added a commit
to RajivTS/hyper
that referenced
this pull request
Aug 29, 2022
Now that the concrete `Body` type has been temporarily replaced with `Recv` in hyperium#2966, we can rename and export `http_body::Body` as just `Body` instead of `HttpBody`. Closes hyperium#2839
seanmonstar
pushed a commit
to RajivTS/hyper
that referenced
this pull request
Aug 29, 2022
Now that the concrete `Body` type has been temporarily replaced with `Recv` in hyperium#2966, we can rename and export `http_body::Body` as just `Body` instead of `HttpBody`. Closes hyperium#2839
seanmonstar
pushed a commit
that referenced
this pull request
Aug 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2963
This currently branches off of #2961