Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ffi): add http1_allow_multiline_headers #2918

Merged
merged 1 commit into from
Jul 19, 2022

Conversation

deantvv
Copy link
Contributor

@deantvv deantvv commented Jul 16, 2022

Close issue #2885

Copy link
Member

@seanmonstar seanmonstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! <3

Looks like the function names are out of sync. The hyper_clientconn_options_http1_allow_multiline_headers name seems preferable to me, since it is an HTTP/1 specific option. I think just running the gen_header.sh script should fix it up for you.

@deantvv deantvv force-pushed the ffi-multiline-header branch from e11e2cd to 8d488a5 Compare July 19, 2022 12:47
@deantvv
Copy link
Contributor Author

deantvv commented Jul 19, 2022

Fixed in new commit.

@deantvv deantvv requested a review from seanmonstar July 19, 2022 12:48
Copy link
Member

@seanmonstar seanmonstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :D

@seanmonstar seanmonstar merged commit 09e3566 into hyperium:master Jul 19, 2022
@seanmonstar
Copy link
Member

Would you want to add the usage in curl? If not, I can a little later, but just checking first.

@deantvv
Copy link
Contributor Author

deantvv commented Jul 26, 2022

I can try that in this weekend, but it would probably need some time for me to understand some curl source code stuff.
Is there any guidance or documentation that I can refer to when I try to do this?
Thanks in advance.

@seanmonstar
Copy link
Member

I tried to add it yesterday, and noticed that curl expects the format of multiline headers to be a little different than hyper treats them, so it'll be more work than expected. I'll need to file an issue on the curl repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add header line obs-folding option to C API
2 participants