fix(http2): received Body::size_hint() now return 0 if implicitly empty
#2715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanmonstar
force-pushed
the
http2-eos-body-size-hint
branch
from
031b44e to
c4745f6
Compare
…mpty An HTTP/2 stream may include a set of headers, and a flag signalling END-STREAM, even if a `content-length` isn't included. hyper wouldn't notice, and so the `Body` would report a size-hint of `0..MAX`. hyper now notices that the stream is ended, and couldn't possibly include any bytes for the body, and thus will give a size-hint of `0` exactly.
seanmonstar
force-pushed
the
http2-eos-body-size-hint
branch
from
c4745f6 to
84935ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An HTTP/2 stream may include a set of headers, and a flag signalling
END-STREAM, even if a
content-lengthisn't included. hyper wouldn'tnotice, and so the
Bodywould report a size-hint of0..MAX. hypernow notices that the stream is ended, and couldn't possibly include any
bytes for the body, and thus will give a size-hint of
0exactly.Closes #2712