feat(headers): Add Pragma header field
#267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| fn parse_header(raw: &[Vec<u8>]) -> Option<Pragma> { | ||
| parsing::from_one_raw_str(raw).and_then(|s: String| { | ||
| let c = s.to_ascii_lowercase(); | ||
| let slice = &c.clone()[]; |
There was a problem hiding this comment.
Ok, bug in code. I want to preserve the upper/lowercase of the value, but the matching should be case insensitive. You will see it in the fixed code.
There was a problem hiding this comment.
If you have a change, you can use git commit --amend to add code to one commit, or git rebase -i master to smash multiple commits into one.
I imagine you can just remove the .clone(), and the rest should work, no?
There was a problem hiding this comment.
You are right .clone() can be simply removed. It was needed for an older version that did not convert the string to lowercase.
Add the HTTP/1.0 `Pragma` header field used to prevent older Caches, that do not understand the `Cache-Control` header field from caching the ressource. Closes #237
|
Rebased and fixed everything. |
|
LGTM. |
reem
added a commit
that referenced
this pull request
Jan 24, 2015
feat(headers): Add `Pragma` header field
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the HTTP/1.0
Pragmaheader field used to prevent older Caches, thatdo not understand the
Cache-Controlheader field from caching the ressource.Closes #237