Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(h2): improve I/O errors emitted by H2Upgraded #2598

Merged
merged 2 commits into from
Jul 21, 2021
Merged

fix(h2): improve I/O errors emitted by H2Upgraded #2598

merged 2 commits into from
Jul 21, 2021

Conversation

nox
Copy link
Contributor

@nox nox commented Jul 19, 2021

No description provided.

seanmonstar
seanmonstar approved these changes Jul 20, 2021
View reviewed changes
Copy link
Member

@seanmonstar seanmonstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks right.

(Have you been able to try out this in your app to see it improves it for you?)

src/proto/h2/mod.rs Show resolved Hide resolved
@nox nox force-pushed the nox/h2-upgraded-errors branch from fd2e80c to 7e4f077 Compare July 21, 2021 14:23
@seanmonstar seanmonstar merged commit f51c677 into master Jul 21, 2021
@seanmonstar seanmonstar deleted the nox/h2-upgraded-errors branch July 21, 2021 15:17
BenxiangGe pushed a commit to BenxiangGe/hyper that referenced this pull request Jul 26, 2021
@nox
fix(http2): improve I/O errors emitted by H2Upgraded (hyperium#2598)
fc1a3b5 
When a `CONNECT` over HTTP2 has been established, and the user tries to write data right when the peer closes the stream, it will no longer return as a "user error". The reset code is checked, and converted into an appropriate `io::ErrorKind`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanmonstar seanmonstar seanmonstar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nox @seanmonstar