Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

omitting default port from Host header #2441

Merged
merged 1 commit into from
Feb 22, 2021
Merged

omitting default port from Host header #2441

merged 1 commit into from
Feb 22, 2021

Conversation

CfirTsabari
Copy link
Contributor

Fixes #2407

@CfirTsabari CfirTsabari force-pushed the cfirtsabari/client-auto-host-header-2407 branch from 619839f to fedd2f7 Compare February 20, 2021 20:18
seanmonstar
seanmonstar approved these changes Feb 22, 2021
View reviewed changes
Copy link
Member

@seanmonstar seanmonstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thank you!

@seanmonstar seanmonstar merged commit 0b11eee into hyperium:master Feb 22, 2021
BenxiangGe pushed a commit to BenxiangGe/hyper that referenced this pull request Jul 26, 2021
@CfirTsabari
fix(client): omit default port from automatic Host headers (hyperium#…
5edc270 
…2441)

Fixes hyperium#2407
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanmonstar seanmonstar seanmonstar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Client auto Host header should omit the port if it is default
2 participants
@CfirTsabari @seanmonstar