remove dependency on tracing's log feature
#2342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
how do I see the gitcop error message? The link just goes to https://gitcop.com/ |
|
Thanks! You can leave the changelog update out, those are automatically construct with a script at release time. And don't worry about gitcop, it's not marked a "required" check, it's just a reminder to me to make the commit message fit the aforementioned script requirements when I squash-merge. |
mikeyhew
force-pushed
the
remove-tracing-log-feature
branch
from
69b1b09 to
d9e78e9
Compare
|
OK, I've removed the changelog update. |
|
Thanks! |
BenxiangGe
pushed a commit
to BenxiangGe/hyper
that referenced
this pull request
Jul 26, 2021
) Closes hyperium#2326 BREAKING CHANGE: hyper no longer emits `log` records automatically. If you need hyper to integrate with a `log` logger (as opposed to `tracing`), you can add `tracing = { version = "0.1", features = ["log"] }` to activate them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2326
I wasn't sure what the right way to update the changelog was, so I just used my best guess. Let me know if I should do something differently.