Allow library consumer to drain a connection #2307
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A draining connection will no longer be used for new requests, but allow existing requests to finish. As discussed on Discord earlier (https://discordapp.com/channels/500028886025895936/670880858630258689/768499073644756992).
This feels like the wrong layer to add this on, since
Connected
is otherwise unaware of any connection pooling going on. It also feels like a smell to me that this will break if the pool starts refreshingConnection::connected()
for any reason. The more appropriate place would probably be to store it on thePoolClient
, but that's getting constructed and destroyed all over the place, so I'm not really sure about what guarantees we have there about the object identity over time.This is also missing a bunch of docs, I just want to find a sound approach before getting into that.