feat(http2): add adaptive window size support using BDP #2138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanmonstar
force-pushed
the
http2-bdp
branch
from
aeacbeb to
f1b79be
Compare
This adds support for calculating the Bandwidth-delay product when using HTTP2. When a DATA frame is received, a PING is sent to the remote. While the PING acknoledgement is outstanding, the amount of bytes of all received DATA frames is accumulated. Once we receive the PING acknowledgement, we calculate the BDP based on the number of received bytes and the round-trip-time of the PING. If we are near the current maximum window size, the size is doubled. It's disabled by default until tested more extensively.
seanmonstar
force-pushed
the
http2-bdp
branch
from
f1b79be to
30012ae
Compare
LucioFranco
approved these changes
Feb 25, 2020
goffrie
reviewed
May 28, 2020
| // Average the first 10 samples | ||
| self.rtt += (rtt - self.rtt) / (self.samples as f64); | ||
| } else { | ||
| self.rtt += (rtt - self.rtt) / 0.9; |
There was a problem hiding this comment.
Is this trying to be an exponential moving average? Should this be * 0.9 then?
There was a problem hiding this comment.
Yea, I inversed it by accident. It's fixed in the latest release.
There was a problem hiding this comment.
Ah my bad, I didn't notice because I was using an old release.
loyd
reviewed
Jun 10, 2023
| } | ||
|
|
||
| // calculate the current bandwidth | ||
| let bw = (bytes as f64) / (self.rtt * 1.5); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for calculating the Bandwidth-delay product when using
HTTP2. When a DATA frame is received, a PING is sent to the remote.
While the PING acknowledgement is outstanding, the amount of bytes of all
received DATA frames is accumulated. Once we receive the PING
acknowledgement, we calculate the BDP based on the number of received
bytes and the round-trip-time of the PING. If we are near the current
maximum window size, the size is doubled.
It's disabled by default until tested more extensively.
cc #1960