Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Implement Clone/Copy on ServiceFn and MakeServiceFn #2104

Merged
merged 2 commits into from
Jan 8, 2020
Merged

feat: Implement Clone/Copy on ServiceFn and MakeServiceFn #2104

merged 2 commits into from
Jan 8, 2020

Conversation

Marwes
Copy link
Contributor

@Marwes Marwes commented Jan 8, 2020

And expose them in docs. Since Clone and Copy can't be propagated out
via impl Service I believe it is better to expose them now.
tower::service_fn already implement Clone and `Copy.

@Marwes
feat: Implement Clone/Copy on ServiceFn and MakeServiceFn
969e4f5 
And expose them in docs. Since Clone and Copy can't be propagated out
via `impl Service` I believe it is better to expose them now.
`tower::service_fn` already implement `Clone` and `Copy.
seanmonstar
seanmonstar requested changes Jan 8, 2020
View reviewed changes
Copy link
Member

@seanmonstar seanmonstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, seems good to add these bounds.

src/service/mod.rs Outdated Show resolved Hide resolved
@seanmonstar seanmonstar merged commit a5720fa into hyperium:master Jan 8, 2020
@Marwes Marwes deleted the service_fn branch January 8, 2020 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanmonstar seanmonstar seanmonstar requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Marwes @seanmonstar