Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create a static reference to interior mutable const #2097

Closed
wants to merge 1 commit into from
Closed

create a static reference to interior mutable const #2097

wants to merge 1 commit into from

Conversation

danieleades
Copy link
Contributor

No description provided.

@danieleades
Copy link
Contributor Author

this is the result of the following clippy lint which i have blindly followed
https://rust-lang.github.io/rust-clippy/master/#declare_interior_mutable_const

I can't see any statistically significant difference in the benches on my machine.

@seanmonstar
Copy link
Member

Huh, that's an odd one.

  1. This really looks like a false positive on clippy's part. This method call doesn't mutate the constant...
  2. Looking at the surrounding code, I think this log may be wrong! It should be logging the header value that was just removed.

@sfackler
Copy link
Contributor

sfackler commented Jan 3, 2020

rust-lang/rust-clippy#3825

@danieleades danieleades closed this Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danieleades @seanmonstar @sfackler