feat(client): impl tower_service::Service for &Client #2089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LucioFranco
approved these changes
Dec 22, 2019
tesaguri
force-pushed
the
service-for-client-ref
branch
from
8c223f4 to
87f6876
Compare
|
Rebased and fixed the build. |
seanmonstar
approved these changes
Jun 25, 2020
|
Thank you! Sorry for forgetting about this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a blanket implementation of
tower_service::Servicefor&mut Sbut not for&S. Sincehyper::Client::requesttakes&selfonly,&Clientcan implementService, allowing users to take advantage of Tower's abstraction without additional ownership restrictions.