fix(client): remove config requirement for Connect #1199
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove requirement when calling client::Config::connector() that the connector implements Connect.
Removing this requirement allows users to set the connector back to UseDefaultConnector. Previously,
this was not possible.
I'm not sure if there's any specific reason for requiring Connect on this method, as far as I can tell from past commits it was just an included part in the original design?
My use case for this is setting the connector back to
UseDefaultConnector
, as well as opening up the possibility for aUseHttpsConnector
or a similar marker type to be used in a wrapper builder aroundConfig
.Tests fail, but as far as I can tell this is only because of deprecated things that hyper is using. Locally, if
#![deny(warnings)]
is temporarily commented out, all tests pass.