Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ContentType::json() has charset attribute #737

Closed
mitsuhiko opened this issue Feb 29, 2016 · 1 comment
Closed

ContentType::json() has charset attribute #737

mitsuhiko opened this issue Feb 29, 2016 · 1 comment
Labels
A-headers Area: headers. C-bug Category: bug. Something is wrong. This is bad! E-easy Effort: easy. A task that would be a great starting point for a new contributor.

Comments

@mitsuhiko
Copy link
Contributor

If you use ContentType::json() a charset attribute is emitted. This is incorrect as the JSON mimetype does not accept a charset attribute. This causes issues with some servers that do not permit it.
@seanmonstar
Copy link
Member

Indeed, this seems like an error.

@seanmonstar seanmonstar added C-bug Category: bug. Something is wrong. This is bad! A-headers Area: headers. E-easy Effort: easy. A task that would be a great starting point for a new contributor. labels Feb 29, 2016
@gsquire gsquire mentioned this issue Mar 9, 2016
Merged
seanmonstar pushed a commit to hyperium/headers that referenced this issue Jul 9, 2018
@gsquire
fix(headers): remove charset from ContentType::json() convenience m…
c9d153f 
…ethod

since the JSON mime type does not accept a charset, this patch removes
it

closes hyperium/hyper#737
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-headers Area: headers. C-bug Category: bug. Something is wrong. This is bad! E-easy Effort: easy. A task that would be a great starting point for a new contributor.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mitsuhiko @seanmonstar