Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make client tests work without server feature #3790

Closed
seanmonstar opened this issue Nov 20, 2024 · 0 comments · Fixed by #3799
Closed

Make client tests work without server feature #3790

seanmonstar opened this issue Nov 20, 2024 · 0 comments · Fixed by #3799
Labels
A-tests Area: tests. C-refactor Category: refactor. This would improve the clarity of internal code. E-easy Effort: easy. A task that would be a great starting point for a new contributor.

Comments

@seanmonstar
Copy link
Member

Running cargo test --features http1,http2,client fails to compile because it uses some types only available when the server feature is also enabled. Fixing this would just require adding or adjusting #[cfg(feature = ...)] attributes, paying attention to the compiler error messages.

For CI, the ffi job can be adjusted to no longer enable server when running the tests.
@seanmonstar seanmonstar added E-easy Effort: easy. A task that would be a great starting point for a new contributor. A-tests Area: tests. C-refactor Category: refactor. This would improve the clarity of internal code. labels Nov 20, 2024
@seanmonstar seanmonstar mentioned this issue Nov 20, 2024
Merged
ionionascu added a commit to ionionascu/hyper that referenced this issue Nov 28, 2024
@ionionascu
fix(server): fix failing tests for server feature
5c6db61 
Update tests that require the server feature to only be compiled when the feature is enabled.
After updating these tests, the server feature is no longer required for the ffi job when
running tests.

Closes hyperium#3790
@ionionascu ionionascu mentioned this issue Nov 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-tests Area: tests. C-refactor Category: refactor. This would improve the clarity of internal code. E-easy Effort: easy. A task that would be a great starting point for a new contributor.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(server): fix failing tests for server feature ionionascu/hyper
1 participant
@seanmonstar