Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No Connection: close on HTTP1 Connection Drain #3720

Closed
Clendenin opened this issue Jul 31, 2024 · 3 comments · Fixed by #3725
Closed

No Connection: close on HTTP1 Connection Drain #3720

Clendenin opened this issue Jul 31, 2024 · 3 comments · Fixed by #3725
Assignees
@seanmonstar
Labels
A-http1 Area: HTTP/1 specific. A-server Area: server. C-bug Category: bug. Something is wrong. This is bad! E-easy Effort: easy. A task that would be a great starting point for a new contributor.

Comments

@Clendenin
Copy link

When HTTP1 connection draining is activated, the Connection: close header is not attached to responses sent to active connections. This prevents active clients from realizing that the server is requesting that the connection be closed and prevents graceful draining of HTTP1 connections.
@Clendenin Clendenin added the C-bug Category: bug. Something is wrong. This is bad! label Jul 31, 2024
@seanmonstar seanmonstar mentioned this issue Aug 2, 2024
Merged
@seanmonstar
Copy link
Member

Thanks for the report! I could have sworn we did this, but then tweaked the test and you're right, not done. PR is up at #3725.

@seanmonstar seanmonstar added A-server Area: server. E-easy Effort: easy. A task that would be a great starting point for a new contributor. A-http1 Area: HTTP/1 specific. labels Aug 2, 2024
@seanmonstar seanmonstar self-assigned this Aug 2, 2024
@Clendenin
Copy link
Author

Thank you @seanmonstar!

@Catwoman08
Copy link

Reopened this until the PR #3725 gets merged.

@Catwoman08 Catwoman08 reopened this Sep 20, 2024
seanmonstar added a commit that referenced this issue Oct 11, 2024
@seanmonstar
fix(http1): send 'connection: close' when connection is ending (#3725)
c86a6bc 
This includes conditions where hyper knows the connection will end after the response, such as a request error that ruins the connection, or when graceful shutdown is triggered.

Closes #3720
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@seanmonstar seanmonstar

Labels
A-http1 Area: HTTP/1 specific. A-server Area: server. C-bug Category: bug. Something is wrong. This is bad! E-easy Effort: easy. A task that would be a great starting point for a new contributor.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(http1): send 'connection: close' during graceful shutdown hyperium/hyper
3 participants
@seanmonstar @Clendenin @Catwoman08