Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport the split server conn modules #3079

Closed
seanmonstar opened this issue Dec 8, 2022 · 1 comment
Closed

Backport the split server conn modules #3079

seanmonstar opened this issue Dec 8, 2022 · 1 comment
Labels
A-server Area: server. C-feature Category: feature. This is adding a new feature. E-medium Effort: medium. Some knowledge of how hyper internal works would be useful. V-0.14.x 0.14.x versions

Comments

@seanmonstar
Copy link
Member

In 1.0, we've split hyper::server::conn::Connection into per-version types. To ease upgrading (see #3052), we can backport the addition of the two modules, hyper::server::conn::{http1, http2}. With them in place, we could then add a deprecation to hyper::server::conn::Connection.

This is very similar in scope to #3053
@seanmonstar seanmonstar added A-server Area: server. C-feature Category: feature. This is adding a new feature. E-medium Effort: medium. Some knowledge of how hyper internal works would be useful. V-0.14.x 0.14.x versions labels Dec 8, 2022
@seanmonstar seanmonstar moved this to Todo in hyper 1.0 Dec 8, 2022
@oddgrd oddgrd mentioned this issue Dec 27, 2022
Merged
@oddgrd oddgrd moved this from Todo to In Progress in hyper 1.0 Jan 6, 2023
seanmonstar pushed a commit that referenced this issue Mar 8, 2023
@oddgrd
feat(server): backport the split server conn modules from 1.0 (#3102)
84881c9 
Closes #3079
@seanmonstar seanmonstar moved this from In Progress to Done in hyper 1.0 May 18, 2023
@seanmonstar seanmonstar moved this from Done to In Progress in hyper 1.0 May 18, 2023
@seanmonstar
Copy link
Member Author

This was done in #3102.

@github-project-automation github-project-automation bot moved this from In Progress to Done in hyper 1.0 May 18, 2023
@seanmonstar seanmonstar mentioned this issue Aug 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-server Area: server. C-feature Category: feature. This is adding a new feature. E-medium Effort: medium. Some knowledge of how hyper internal works would be useful. V-0.14.x 0.14.x versions
Projects
No open projects
hyper 1.0
Status: Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@seanmonstar