Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timer methods should return Pin<Box<dyn Sleep>> and Sleep should drop the Unpin requirement #3028

Closed
sfackler opened this issue Oct 28, 2022 · 0 comments · Fixed by #3037
Closed

Timer methods should return Pin<Box<dyn Sleep>> and Sleep should drop the Unpin requirement #3028

sfackler opened this issue Oct 28, 2022 · 0 comments · Fixed by #3037
Labels
A-rt Area: runtime traits/utils B-breaking-change Blocked: this is an "API breaking change". C-bug Category: bug. Something is wrong. This is bad!
Milestone
1.0 RC2

Comments

@sfackler
Copy link
Contributor

Otherwise, you need to double-box !Unpin timer futures like Tokio's.
@sfackler sfackler added the C-bug Category: bug. Something is wrong. This is bad! label Oct 28, 2022
@sfackler sfackler mentioned this issue Oct 29, 2022
Merged
@seanmonstar seanmonstar added B-breaking-change Blocked: this is an "API breaking change". A-rt Area: runtime traits/utils labels Nov 8, 2022
@seanmonstar seanmonstar moved this to Todo in hyper 1.0 Nov 8, 2022
@seanmonstar seanmonstar added this to the 1.0 RC2 milestone Nov 8, 2022
@seanmonstar seanmonstar moved this from Todo to In Progress in hyper 1.0 Nov 8, 2022
Repository owner moved this from In Progress to Done in hyper 1.0 Dec 13, 2022
seanmonstar pushed a commit that referenced this issue Dec 13, 2022
@sfackler
feat(rt): Clean up Timer trait (#3037)
8790fee 
Closes #3028 

BREAKING CHANGE: The return types of `Timer` have been changed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-rt Area: runtime traits/utils B-breaking-change Blocked: this is an "API breaking change". C-bug Category: bug. Something is wrong. This is bad!
Projects
No open projects
hyper 1.0
Status: Done
Milestone
1.0 RC2
Development

Successfully merging a pull request may close this issue.

refactor(rt): Clean up Timer trait sfackler/hyper
2 participants
@seanmonstar @sfackler