Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to use new http-body trait #3010

Closed
seanmonstar opened this issue Oct 12, 2022 · 0 comments · Fixed by #3020
Closed

Update to use new http-body trait #3010

seanmonstar opened this issue Oct 12, 2022 · 0 comments · Fixed by #3020
Assignees
@LucioFranco
Labels
A-body Area: body streaming. C-feature Category: feature. This is adding a new feature. E-medium Effort: medium. Some knowledge of how hyper internal works would be useful.
Milestone
1.0 RC1

Comments

@seanmonstar
Copy link
Member

seanmonstar commented Oct 12, 2022 •
edited
Loading

With #2840 completed, we need to update hyper to use the new trait.
@seanmonstar seanmonstar added this to the 1.0 RC1 milestone Oct 12, 2022
@LucioFranco LucioFranco mentioned this issue Oct 14, 2022
Merged
@seanmonstar seanmonstar moved this from Todo to In Progress in hyper 1.0 Oct 14, 2022
@seanmonstar seanmonstar mentioned this issue Oct 24, 2022
Merged
seanmonstar added a commit that referenced this issue Oct 24, 2022
@seanmonstar
feat(body): update Body trait to use Frames (#3020)
0888623 
The `Body` trait was adjusted to be forwards compatible with adding new
frame types. That resulted in changing from `poll_data` and `poll_trailers`
to a single `poll_frame` function. More can be learned from the proposal
in #2840.

Closes #3010

BREAKING CHANGE: The polling functions of the `Body` trait have been
  redesigned.

  The free functions `hyper::body::to_bytes` and `aggregate` have been
  removed. Similar functionality is on
  `http_body_util::BodyExt::collect`.
Repository owner moved this from In Progress to Done in hyper 1.0 Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LucioFranco LucioFranco

Labels
A-body Area: body streaming. C-feature Category: feature. This is adding a new feature. E-medium Effort: medium. Some knowledge of how hyper internal works would be useful.
Projects
No open projects
hyper 1.0
Status: Done
Milestone
1.0 RC1
Development

Successfully merging a pull request may close this issue.

feat(body): update Body trait to use Frames hyperium/hyper
2 participants
@seanmonstar @LucioFranco