Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add builder option for HTTP2 max concurrent streams #1772

Closed
2 tasks
seanmonstar opened this issue Feb 28, 2019 · 0 comments
Closed
2 tasks

Add builder option for HTTP2 max concurrent streams #1772

seanmonstar opened this issue Feb 28, 2019 · 0 comments
Labels
A-http2 Area: HTTP/2 specific. A-server Area: server. C-feature Category: feature. This is adding a new feature. E-easy Effort: easy. A task that would be a great starting point for a new contributor.

Comments

@seanmonstar
Copy link
Member

The SETTINGS_MAX_CONCURRENT_STREAMS option controls how many concurrent streams a peer is willing to receive. Since we don't yet has push promises, this only makes sense in the server case. The corresponding method exists on the h2 type.

  • server::Builder::http2_max_concurrent_streams
  • server::conn::Http::http2_max_concurrent_streams
@seanmonstar seanmonstar added A-server Area: server. E-easy Effort: easy. A task that would be a great starting point for a new contributor. C-feature Category: feature. This is adding a new feature. A-http2 Area: HTTP/2 specific. labels Feb 28, 2019
@seanmonstar seanmonstar changed the title Add builder option for HTTP max concurrent streams Add builder option for HTTP2 max concurrent streams Feb 28, 2019
seanmonstar added a commit that referenced this issue Feb 28, 2019
@seanmonstar
feat(server): add http2_max_concurrent_streams builder option
ab71f8c 
Closes #1772
@seanmonstar seanmonstar mentioned this issue Feb 28, 2019
Merged
seanmonstar added a commit that referenced this issue Mar 1, 2019
@seanmonstar
feat(server): add http2_max_concurrent_streams builder option
cbae429 
Closes #1772
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-http2 Area: HTTP/2 specific. A-server Area: server. C-feature Category: feature. This is adding a new feature. E-easy Effort: easy. A task that would be a great starting point for a new contributor.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@seanmonstar