Skip to content

feat: impl Connection for TokioIo #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 14, 2024
Merged

feat: impl Connection for TokioIo #117

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions src/client/legacy/connect/http.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -438,12 +438,10 @@ where
}
}

impl Connection for TokioIo<TcpStream> {
impl Connection for TcpStream {
fn connected(&self) -> Connected {
let connected = Connected::new();
if let (Ok(remote_addr), Ok(local_addr)) =
(self.inner().peer_addr(), self.inner().local_addr())
{
if let (Ok(remote_addr), Ok(local_addr)) = (self.peer_addr(), self.local_addr()) {
connected.extra(HttpInfo {
remote_addr,
local_addr,
Expand All @@ -454,6 +452,17 @@ impl Connection for TokioIo<TcpStream> {
}
}

// Implement `Connection` for generic `TokioIo<T>` so that external crates can
// implement their own `HttpConnector` with `TokioIo<CustomTcpStream>`.
impl<T> Connection for TokioIo<T>
where
T: Connection,
{
fn connected(&self) -> Connected {
self.inner().connected()
}
}

impl HttpInfo {
/// Get the remote address of the transport used.
pub fn remote_addr(&self) -> SocketAddr {
Expand Down