Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for HTTP QUERY method #717

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jgresty
Copy link

@jgresty jgresty commented Oct 11, 2024

The HTTP QUERY method is a means of making a safe, idempotent request that contains content. The primary motivator for this case is graphql, replacing HTTP POST for read only requests, however it is application agnostic.

This method is still in draft but stable enough where it is unlikely to change for this implementation.

https://httpwg.org/http-extensions/draft-ietf-httpbis-safe-method-w-body.html

The HTTP QUERY method is a means of making a safe, idempotent request
that contains content. The primary motivator for this case is graphql,
replacing HTTP POST for read only requests, however it is application
agnostic.

This method is still in draft but stable enough where it is unlikely to
change for this implementation.

https://httpwg.org/http-extensions/draft-ietf-httpbis-safe-method-w-body.html
@gdubicki
Copy link

I think you should add support for the accept-query header too, @jgresty, see and feel free to take the code from my draft PR: #745

@seanmonstar
Copy link
Member

I'd prefer to leave off the header for now. I think the method is probably a fine addition, but I'd like to wait for real world usage of the header to possibly grow (or for servers to not care to send it), before deciding to add to the library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants