Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(lib): apply small refactoring #677

Merged
merged 19 commits into from
Feb 19, 2024
Merged

refactor(lib): apply small refactoring #677

merged 19 commits into from
Feb 19, 2024

Conversation

tottoto
Copy link
Contributor

@tottoto tottoto commented Feb 16, 2024

Applies miscellaneous refactoring.

@tottoto
refactor(lib): remove redundant field name
c54d8e0
@tottoto
refactor(lib): refactor conditional expression
18fb2bc
@tottoto
refactor(lib): remove redundant reference
fae9e0d
@tottoto
refactor(uri): use more idiomatic api
4a27676
@tottoto
refactor(header): remove redundant type conversion
e981e58
@tottoto
refactor(header): remove redundant slicing
67bfb42
@tottoto
refactor(uri): replace single string with character
eb42b0e
@tottoto
refactor(lib): refactor redundant closure
91cc6e9
@tottoto
refactor(lib): remove unused lifetime parameter
acf6ee4
@tottoto
refactor(header): remove manual deref
a64956a
@tottoto
refactor(header): resolve non-canonical PartialOrd implementation
5663e23
@tottoto
chore(header): make HeaderValue Hash implementation consistent with Eq
74e930d
@tottoto
refactor(lib): use to_owned to clarify the purpose
741f0df
@tottoto
refactor(header): ownership is not needed to iterate
4e47afb
@tottoto
refactor(status): remove redundant static lifetime
5cace4a
@tottoto
refactor(header): add comment and lint allowing to panic in const con…
94144fc 
…text workaround
@tottoto
doc(header): add panics and safety section to document
1d8451b
@tottoto tottoto changed the title Small refactoring refactor(lib): apply small refactoring Feb 16, 2024
seanmonstar
seanmonstar reviewed Feb 16, 2024
View reviewed changes
Copy link
Member

@seanmonstar seanmonstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

src/request.rs Outdated Show resolved Hide resolved
@seanmonstar seanmonstar merged commit c03cc8b into hyperium:master Feb 19, 2024
10 checks passed
@tottoto tottoto deleted the small-refactoring branch February 19, 2024 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanmonstar seanmonstar seanmonstar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tottoto @seanmonstar