doc(core): Header encode method convert header to HeaderValue #161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanmonstar
reviewed
Jan 19, 2024
headers-core/src/lib.rs
Outdated
| I: Iterator<Item = &'i HeaderValue>; | ||
|
|
||
| /// Encode this type to a `HeaderMap`. | ||
| /// Encode this type to a [`HeaderValue`]. |
Member
There was a problem hiding this comment.
Ah, well, sorta. The argument is a container of HeaderValues. Normally, it will be an private type that's like an Entry. But since it's generic, unit tests could just pass a Vec<_>.
Contributor
Author
There was a problem hiding this comment.
Added a detailed document, which would be more helpful.
seanmonstar
approved these changes
Jan 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Header'sencodemethod seems to convert the receiver toHeaderValue.