Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove PluginMessage #820

Merged
merged 1 commit into from
Jan 19, 2025
Merged

fix: remove PluginMessage #820

merged 1 commit into from
Jan 19, 2025

Conversation

TestingPlant
Copy link
Collaborator

PluginMessage was never consumed anywhere and caused an abort because of this.

@github-actions github-actions bot added the fix label Jan 19, 2025
Copy link

Benchmark Results for general

ray_intersection/aabb_size_0.1                     [  24.0 ns ...  23.9 ns ]      -0.23%
ray_intersection/aabb_size_1                       [  24.0 ns ...  23.9 ns ]      -0.10%
ray_intersection/aabb_size_10                      [  23.1 ns ...  22.9 ns ]      -0.75%
ray_intersection/ray_distance_1                    [   5.2 ns ...   5.2 ns ]      -0.32%
ray_intersection/ray_distance_5                    [   9.4 ns ...   9.4 ns ]      -0.05%
ray_intersection/ray_distance_20                   [   9.5 ns ...   9.5 ns ]      +0.01%
overlap/no_overlap                                 [  31.1 ns ...  30.4 ns ]      -2.47%
overlap/partial_overlap                            [  31.1 ns ...  31.1 ns ]      -0.09%
overlap/full_containment                           [  24.0 ns ...  23.9 ns ]      -0.52%
point_containment/inside                           [   5.9 ns ...   5.9 ns ]      +0.22%
point_containment/outside                          [   5.4 ns ...   5.4 ns ]      +0.01%
point_containment/boundary                         [   6.4 ns ...   6.5 ns ]      +0.26%

Comparing to a1bb588

Copy link

codecov bot commented Jan 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 24.65%. Comparing base (a1bb588) to head (0963467).
Report is 1 commits behind head on main.

@@            Coverage Diff             @@
##             main     #820      +/-   ##
==========================================
+ Coverage   24.62%   24.65%   +0.02%     
==========================================
  Files         159      159              
  Lines       15905    15878      -27     
  Branches      362      361       -1     
==========================================
- Hits         3917     3915       -2     
+ Misses      11887    11862      -25     
  Partials      101      101              
Files with missing lines Coverage Δ
crates/hyperion/src/simulation/event.rs 0.00% <ø> (ø)
crates/hyperion/src/simulation/handlers.rs 3.96% <ø> (-0.07%) ⬇️
crates/hyperion/src/storage/event/queue/mod.rs 90.32% <ø> (-0.31%) ⬇️

PluginMessage was never consumed anywhere and caused an abort because of
this.
@TestingPlant TestingPlant force-pushed the fix-remove-plugin-message branch from 78a1398 to 0963467 Compare January 19, 2025 19:54
Copy link

Benchmark Results for general

ray_intersection/aabb_size_0.1                     [  24.1 ns ...  24.1 ns ]      -0.14%
ray_intersection/aabb_size_1                       [  24.1 ns ...  24.1 ns ]      -0.18%
ray_intersection/aabb_size_10                      [  23.0 ns ...  23.0 ns ]      +0.01%
ray_intersection/ray_distance_1                    [   5.2 ns ...   5.2 ns ]      -0.06%
ray_intersection/ray_distance_5                    [   9.4 ns ...   9.4 ns ]      +0.18%
ray_intersection/ray_distance_20                   [   9.4 ns ...   9.4 ns ]      -0.04%
overlap/no_overlap                                 [  31.2 ns ...  30.4 ns ]      -2.68%
overlap/partial_overlap                            [  30.2 ns ...  31.2 ns ]      +3.13%
overlap/full_containment                           [  22.9 ns ...  22.8 ns ]      -0.08%
point_containment/inside                           [   5.9 ns ...   5.9 ns ]      +0.04%
point_containment/outside                          [   5.3 ns ...   5.4 ns ]      +0.35%
point_containment/boundary                         [   5.8 ns ...   5.8 ns ]      -0.29%

Comparing to a1bb588

@andrewgazelka andrewgazelka added this pull request to the merge queue Jan 19, 2025
Merged via the queue into main with commit cf21cd7 Jan 19, 2025
11 checks passed
@andrewgazelka andrewgazelka deleted the fix-remove-plugin-message branch January 19, 2025 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants