Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use libvoidstar.so properly #786

Merged
merged 3 commits into from
Dec 23, 2024
Merged

feat: use libvoidstar.so properly #786

merged 3 commits into from
Dec 23, 2024

Conversation

andrewgazelka
Copy link
Collaborator

No description provided.

Copy link
Collaborator Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

Benchmark Results for general

ray_intersection/aabb_size_0.1                     [  22.9 ns ...  22.9 ns ]      -0.01%
ray_intersection/aabb_size_1                       [  22.1 ns ...  22.1 ns ]      -0.07%
ray_intersection/aabb_size_10                      [  23.0 ns ...  23.0 ns ]      -0.02%
ray_intersection/ray_distance_1                    [   5.1 ns ...   5.1 ns ]      +0.02%
ray_intersection/ray_distance_5                    [   9.6 ns ...   9.6 ns ]      -0.01%
ray_intersection/ray_distance_20                   [   9.6 ns ...   9.6 ns ]      -0.04%
overlap/no_overlap                                 [  37.9 ns ...  38.6 ns ]      +1.93%
overlap/partial_overlap                            [  38.6 ns ...  37.7 ns ]      -2.08%
overlap/full_containment                           [  33.2 ns ...  33.3 ns ]      +0.08%
point_containment/inside                           [   6.7 ns ...   6.7 ns ]      +0.12%
point_containment/outside                          [   5.4 ns ...   5.4 ns ]      -0.05%
point_containment/boundary                         [   5.8 ns ...   5.8 ns ]      +0.03%

Comparing to 1aebab9

Copy link

Benchmark Results for general

ray_intersection/aabb_size_0.1                     [  22.4 ns ...  22.8 ns ]      +1.89%
ray_intersection/aabb_size_1                       [  22.2 ns ...  22.3 ns ]      +0.63%
ray_intersection/aabb_size_10                      [  23.0 ns ...  23.2 ns ]      +0.85%
ray_intersection/ray_distance_1                    [   5.1 ns ...   5.1 ns ]      -0.23%
ray_intersection/ray_distance_5                    [   9.7 ns ...   9.7 ns ]      -0.08%
ray_intersection/ray_distance_20                   [   9.6 ns ...   9.6 ns ]      -0.04%
overlap/no_overlap                                 [  30.1 ns ...  31.0 ns ]      +3.08%
overlap/partial_overlap                            [  31.1 ns ...  30.1 ns ]      -3.11%
overlap/full_containment                           [  22.7 ns ...  22.8 ns ]      +0.62%
point_containment/inside                           [   6.0 ns ...   6.0 ns ]      +0.01%
point_containment/outside                          [   5.3 ns ...   5.3 ns ]      -0.11%
point_containment/boundary                         [   5.8 ns ...   5.8 ns ]      -0.35%

Comparing to 1aebab9

Dockerfile Outdated Show resolved Hide resolved
@andrewgazelka andrewgazelka changed the title build: use libvoidstar.so properly feat: use libvoidstar.so properly Dec 23, 2024
@andrewgazelka andrewgazelka marked this pull request as ready for review December 23, 2024 18:59
@github-actions github-actions bot added the feat label Dec 23, 2024
Copy link

Benchmark Results for general

ray_intersection/aabb_size_0.1                     [  22.0 ns ...  22.0 ns ]      +0.30%
ray_intersection/aabb_size_1                       [  22.2 ns ...  22.2 ns ]      -0.03%
ray_intersection/aabb_size_10                      [  23.1 ns ...  23.2 ns ]      +0.22%
ray_intersection/ray_distance_1                    [   5.3 ns ...   5.3 ns ]      +0.12%
ray_intersection/ray_distance_5                    [   9.6 ns ...   9.6 ns ]      -0.03%
ray_intersection/ray_distance_20                   [   9.6 ns ...   9.6 ns ]      -0.04%
overlap/no_overlap                                 [  31.0 ns ...  31.8 ns ]      +2.82%
overlap/partial_overlap                            [  31.8 ns ...  31.1 ns ]      -2.22%
overlap/full_containment                           [  22.6 ns ...  23.7 ns ]      +4.55%*
point_containment/inside                           [   5.9 ns ...   6.0 ns ]      +0.09%
point_containment/outside                          [   5.4 ns ...   5.4 ns ]      +0.25%
point_containment/boundary                         [   5.8 ns ...   5.8 ns ]      -0.09%

Comparing to 1aebab9

@andrewgazelka andrewgazelka merged commit 68f06fb into main Dec 23, 2024
5 of 6 checks passed
@andrewgazelka andrewgazelka deleted the andrew/add-so branch December 23, 2024 19:01
@addbounty
Copy link

Bounty Details
Bounty Status • Instant payouts • Secure escrow
💡 Click the badge above to claim or fund this bounty

1 similar comment
@addbounty
Copy link

Bounty Details
Bounty Status • Instant payouts • Secure escrow
💡 Click the badge above to claim or fund this bounty

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants