This repository was archived by the owner on Feb 8, 2021. It is now read-only.
[WIP]use fifo files in non-console io mode #483
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original design use current progress' stdio and pass them to containerd in create stage. This will lead to `-d` flag behave wired, since you've already passed stdin to container. This PR enable two phase io connection use fifo pipes. In create stage, create three named fifo files as stdio passed to container. In start stage, open these three files and bind them with stand input/output using `io.Copy()` Signed-off-by: Crazykev <[email protected]>
8 tasks
Crazykev
changed the title
|
#537 is merged, could you check if the problem is fixed please? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #481
The original design use current progress' stdio and pass them to
containerd in create stage. This will lead to
-dflag behave wired,since you've already passed stdin to container.
This PR enable two phase io connection use fifo pipes. In create stage,
create three named fifo files as stdio passed to container. In start
stage, open these three files and bind them with stand input/output
using
io.Copy()/cc @laijs
Signed-off-by: Crazykev [email protected]