-
Notifications
You must be signed in to change notification settings - Fork 7
[HYPER-181] add cryptographic signature support to record lexicons (resubmission of #170) #219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
39d7547
feat: add cryptographic signature support to record lexicons
aspiers 1c793db
refactor: align signature lexicons with ATProto Attestation Specifica…
aspiers a85808f
test: rename validate-signatures-on-record to validate-signature-defs
aspiers cb358a6
docs: clarify test-naming convention allows judgment for cross-cuttin…
aspiers bfb50d0
feat: restructure inline def into signature.defs#inline and extend si…
aspiers 0384dad
docs(erd): omit signature lexicons from ERD with explanatory comment
aspiers 5133898
docs(skill): add signature coverage to building-with-hypercerts-lexicons
aspiers da06ce0
docs: point primary spec links at the canonical Tangled URL
aspiers 3627bc7
docs: restructure signing example to build signature before embedding
aspiers d51670d
test: extract and execute signing-example code blocks from docs
aspiers a6f7659
docs(changeset): drop duplicate signing-curve summary
aspiers 867d2d0
fix review feedback on signing example and CI node version
Copilot 717d7c0
refine signing example review fixes
Copilot e52b432
chore(eslint): ignore .git-worktrees/
aspiers 38fde95
docs(changeset): condense signing-support summary and note doc updates
aspiers bf5c0dd
docs(signing): add key-management callout and persistence step
aspiers cb4cd1f
chore: regenerate SCHEMAS.md and ignore .git-worktrees/ in prettier
aspiers File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| --- | ||
| "@hypercerts-org/lexicon": minor | ||
| --- | ||
|
|
||
| Add optional cryptographic signature support to all 21 record lexicons. | ||
|
|
||
| **Non-breaking:** signatures are optional on every record. | ||
|
|
||
| - New `app.certified.signature.defs` with `#list` (open union of inline signatures and `com.atproto.repo.strongRef` references) and `#inline` (raw ECDSA `(r,s)` bytes plus a DID verification method reference; signing curve derived from the verification method's multicodec prefix). | ||
| - New `app.certified.signature.proof` record for remote attestations. | ||
| - Every record lexicon gains an optional `signatures` property referencing `#list`. | ||
| - `README.md`, `SCHEMAS.md`, and the `building-with-hypercerts-lexicons` agent skill all gain a "Cryptographic Signatures" section with a worked end-to-end signing example. | ||
|
|
||
| On-the-wire shape, signing procedure, and verification procedure all conform to Nick Gerakines' [ATProtocol Attestation Specification](https://tangled.org/strings/did:plc:cbkjy5n7bk3ax2wplmtjofq2/3m3fy2xuahc22) (see also the [accompanying blog post](https://ngerakines.leaflet.pub/3m3idxul5hc2r)). | ||
|
|
||
| On `app.certified.link.evm` the existing EIP-712 `proof` field (wallet consent) and the new `signatures` array (record provenance) are complementary and do not conflict. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -14,3 +14,4 @@ tmp/ | |
| .codex/ | ||
| .gemini/ | ||
| .beads/ | ||
| .git-worktrees/ | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.