Skip to content

chore(groups): retire the /groups index in favor of the profile Groups tab - #197

Merged
holkexyz merged 1 commit into
stagingfrom
chore/retire-groups-index
Jun 17, 2026
Merged

chore(groups): retire the /groups index in favor of the profile Groups tab#197
holkexyz merged 1 commit into
stagingfrom
chore/retire-groups-index

Conversation

@holkexyz

Copy link
Copy Markdown
Member

Follow-up to #192. The standalone /groups listing is replaced by the profile Groups tab (/{handle}?tab=groups), so the index URL no longer needs its own page.

Changes

  • /groups now redirects to /home (no 404 for old links). The sub-routes — /groups/create, /groups/import, /groups/[groupDid] — are unchanged.
  • Dropped /groups from the navbar root-path set (nothing links to the index anymore).
  • Pointed the create/import success + cancel redirects, and the org-settings remove-group redirect, at /home.
  • Removed the obsolete leave-group dialog test and the /groups public-view cases (old, removed functionality); kept /endorsements coverage.

Verification

  • npx tsc --noEmit, npm run typecheck:test, and npm run lint (65 warnings / 0 errors, unchanged) all clean.
  • vitest 729/729 pass.

🤖 Generated with Claude Code

The standalone /groups listing is replaced by the profile Groups tab
(/{handle}?tab=groups), so the index URL no longer needs its own page.

- /groups now redirects to /home (no 404 for old links); the sub-routes
  (/groups/create, /groups/import, /groups/[groupDid]) are unchanged.
- Drop /groups from the navbar root-path set (nothing links to it).
- Point create/import success + cancel redirects at /home (and the
  remove-group redirect in org settings).
- Remove the obsolete leave-group dialog test and the /groups public-view
  cases (old, removed functionality); keep the /endorsements coverage.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@vercel

vercel Bot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
certified-app Ready Ready Preview, Comment Jun 17, 2026 7:40pm

Request Review

@coderabbitai

coderabbitai Bot commented Jun 17, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: a0c4b521-eb24-477f-ba36-e7afca686477

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/retire-groups-index

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@holkexyz
holkexyz marked this pull request as ready for review June 17, 2026 19:42
@holkexyz
holkexyz merged commit e50b2ad into staging Jun 17, 2026
3 of 4 checks passed
@holkexyz
holkexyz deleted the chore/retire-groups-index branch June 17, 2026 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant