Skip to content

Funding: decide fate of the dormant server-side confirmedBy filter (magic-indexer #214) #179

Description

@hb-agent

The Funding "Confirmed by" filter is applied client-side over the loaded window. A server-side confirmedBy arg is plumbed through fetchFundingReceipts → the indexer GraphQL op but is ignored upstream until magic-indexer #214 ships. It is currently dormant scaffolding — kept and documented in PR #178 (src/components/explore-page/funding-confirmed-by-popover.tsx), not removed.

Why it matters: client-side filtering only sees the loaded window (≤100 receipts/page), so the filter and its counts are window-limited (the documented >100-receipt cap). A real server-side filter would make filtering accurate and paginate correctly.

Recommendation: Keep the scaffolding as-is until magic-indexer #214 lands, then wire it through. Don't remove it now — it's deliberate, low-cost, and signposts the dependency.

Alternatives:

  • Remove the dormant plumbing now to shrink surface area and re-add when fix(profile): truncate sidebar display name instead of overflowing #214 ships. (Loses the signpost; small churn now and later.)
  • Wire a partial version against the current single-nullable-DID arg. Not viable — the real filter is multi-axis (Both/Sender/Recipient role buckets + a set of third-party DIDs), which a single nullable-DID arg can't express.

Refs: PR #178, docs/quality-pass-2026-06-16/review-round-1-decisions.md. Blocked on magic-indexer #214.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions