-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): Adding fuzzy error mapping in core #468
Comments
TillaTheHun0
added a commit
that referenced
this issue
Feb 22, 2022
TillaTheHun0
added a commit
that referenced
this issue
Feb 22, 2022
TillaTheHun0
added a commit
that referenced
this issue
Feb 22, 2022
TillaTheHun0
added a commit
that referenced
this issue
Feb 22, 2022
TillaTheHun0
added a commit
that referenced
this issue
Feb 23, 2022
TillaTheHun0
added a commit
that referenced
this issue
Feb 23, 2022
TillaTheHun0
added a commit
that referenced
this issue
Feb 23, 2022
TillaTheHun0
added a commit
that referenced
this issue
Feb 24, 2022
TillaTheHun0
added a commit
that referenced
this issue
Feb 28, 2022
TillaTheHun0
added a commit
that referenced
this issue
Mar 2, 2022
fix: update all ports to support success + error union response #468
TillaTheHun0
added a commit
that referenced
this issue
Mar 8, 2022
…ponses #468 Since errors can be resolved now, there was a chance that hyper errors would be ran through the data service id mapping and monitoring chain. With this change only successful responses will flow through the mapping and monitoring The id monitoring will go away, but shouldn't affect the code flow with these changes
TillaTheHun0
added a commit
that referenced
this issue
Mar 8, 2022
fix(core): only run data service id mapping/monitoring on success responses #468
TillaTheHun0
added a commit
that referenced
this issue
Mar 8, 2022
TillaTheHun0
added a commit
that referenced
this issue
Mar 21, 2022
feat(core): indicate error in event payload from core #468
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In most cases, hyper adapters will return a resolved promise with either a hyper success response or a hyper error.
In the case of unhandled exceptions, an adapter may return a rejected promise with any value.
Core needs to implement some fuzzy mapping such that the value in a rejected promise is mapped to a hyper error and transformed into a resolved promise. It should also attach the
originalError
to the rejected promise value.The only time core should return a rejected promise to the hyper app is if there is a catastrophic error within the core.
The text was updated successfully, but these errors were encountered: