Skip to content

Conversation

@timmaffett
Copy link
Contributor

This PR adds a new flag hideHandlesWhenNotResizable which allows user to request that the handles be automatically hidden when not resizable.

This PR also extends the example to include a switch to set hideHandlesWhenNotResizable`, as well as an additional switch to add a second ImageBox() - the model and imagebox have been extended to allow this, as well as generalizing ImageBox() to not be as hard coded to the specific model rect/flip flag and asset image name.

It also adjusts the const declarations so that it does not have analysis issues (which may be because I am on master branch of flutter).

@timmaffett
Copy link
Contributor Author

I will also note that the example really is not well architected for having multiple boxes, but I do think it is important to have this because I would imagine that most users of this library would be using it on multiple items, unless of course they only used it on the currently selected item within their architecture.
I think a more generalized example with better architecture for multiple items would be useful for users to illustrate how to do this properly.

@BirjuVachhani
Copy link
Collaborator

@timmaffett PR build and quality checks are failing. Can you check if everything is formatted properly and the PR is compatible with Flutter stable channel?

@timmaffett
Copy link
Contributor Author

I have corrected the dart format issue. It should now pass the workflow. Sorry about that!

@timmaffett
Copy link
Contributor Author

..and I have reverted the const changes that my master channel dart analyze was suggesting - I didn't realize that master<->stable was so different about this!

@BirjuVachhani BirjuVachhani reopened this Apr 6, 2023
@BirjuVachhani BirjuVachhani reopened this Apr 6, 2023
@BirjuVachhani BirjuVachhani reopened this Apr 6, 2023
@BirjuVachhani BirjuVachhani reopened this Apr 6, 2023
BirjuVachhani added a commit that referenced this pull request Apr 6, 2023
@BirjuVachhani
Copy link
Collaborator

Sorry for all the notifications & inconvenience. I was trying to fix workflows for building demo links for PRs but seems like Github doesn't allow using secrets for PR workflows so I can't deploy.

@BirjuVachhani
Copy link
Collaborator

LGTM

@BirjuVachhani BirjuVachhani merged commit 10f2098 into hyper-designed:main Apr 6, 2023
@BirjuVachhani
Copy link
Collaborator

@timmaffett Thank you for your contributions! 🎉

BirjuVachhani added a commit that referenced this pull request Apr 30, 2023
- Add more tests.
BirjuVachhani added a commit that referenced this pull request May 31, 2023
- Add more tests.
SaadArdati added a commit that referenced this pull request Jun 7, 2024
SaadArdati added a commit that referenced this pull request Aug 14, 2024
SaadArdati added a commit that referenced this pull request Feb 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants