-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add skip-wheel to build only sdists #98
Conversation
Thanks for being so quick! Happy to help put in a review if you need it, but I don't think it requires one. |
i think i've finally got it, but happy if you could take a look if it makes sense |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does make sense, thank you! Otherwise – as discussed, there are four possibilities:
- Build an sdist (this PR)
- Build just a wheel
- Build an sdist and then a wheel from it – edit: oops, that is already the current functionality :)
- Build an sdist and a wheel from tree, separately
I suppose the rest of the three two could be taken up in a follow-up PR (only if you want to provide that)?
I don’t think suppressing the sdist has any value whatsoever so I don’t think it’s worth the complexity. I’m not sure how I feel about 4 – it seems like an anti-pattern since it should be possible to build the identical wheel from an sdist and this is the way to enforce it? |
I don't think wheels built that way would be identical – building a wheel from an sdist would mean that it respects your One thing I agree on is that this behaviour breaks reproducible wheels when building from an sdist downloaded off PyPI or those being built from a git / other version control source – I definitely don't do this for my own projects... but maybe if |
Could you please tag a release so we can easily use this feature? Cheers. |
fixes #83